Skip to content

chore(drag-drop): Fix compilation in TS3.6. #17217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2019
Merged

chore(drag-drop): Fix compilation in TS3.6. #17217

merged 1 commit into from
Oct 3, 2019

Conversation

mprobst
Copy link
Contributor

@mprobst mprobst commented Sep 27, 2019

This version compiles in 3.5 and 3.6.

@mprobst
chore(drag-drop): Fix compilation in TS3.6.
f822248 
This version compiles in 3.5 and 3.6.
@mprobst mprobst requested a review from jelbourn September 27, 2019 13:08
@mprobst mprobst requested a review from crisbeto as a code owner September 27, 2019 13:08
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 27, 2019
jelbourn
jelbourn approved these changes Sep 27, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Sep 27, 2019
crisbeto
crisbeto approved these changes Sep 28, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added this to the 9.0.0 milestone Oct 2, 2019
@mmalerba mmalerba merged commit 361d1cf into master Oct 3, 2019
mmalerba pushed a commit that referenced this pull request Oct 8, 2019
@mprobst @mmalerba
chore(drag-drop): Fix compilation in TS3.6. (#17217)
3e37128 
This version compiles in 3.5 and 3.6.

(cherry picked from commit 361d1cf)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mprobst @jelbourn @crisbeto @googlebot @mmalerba